Hi Andy > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Sent: Tuesday, June 22, 2021 10:40 PM > To: Justin He <Justin.He@xxxxxxx> > Cc: Petr Mladek <pmladek@xxxxxxxx>; Steven Rostedt <rostedt@xxxxxxxxxxx>; > Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>; Rasmus Villemoes > <linux@xxxxxxxxxxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Alexander > Viro <viro@xxxxxxxxxxxxxxxxxx>; Linus Torvalds <torvalds@linux- > foundation.org>; Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>; Eric > Biggers <ebiggers@xxxxxxxxxx>; Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx>; > linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > fsdevel@xxxxxxxxxxxxxxx; Matthew Wilcox <willy@xxxxxxxxxxxxx>; Christoph > Hellwig <hch@xxxxxxxxxxxxx>; nd <nd@xxxxxxx> > Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path > of file > > On Tue, Jun 22, 2021 at 10:06:32PM +0800, Jia He wrote: > > Previously, the specifier '%pD' is for printing dentry name of struct > > file. It may not be perfect (by default it only prints one component.) > > > > As suggested by Linus [1]: > > Citing is better looked when you shift right it by two white spaces. Okay, I plan to cite it with "> " > > > A dentry has a parent, but at the same time, a dentry really does > > inherently have "one name" (and given just the dentry pointers, you > > can't show mount-related parenthood, so in many ways the "show just > > one name" makes sense for "%pd" in ways it doesn't necessarily for > > "%pD"). But while a dentry arguably has that "one primary component", > > a _file_ is certainly not exclusively about that last component. > > > > Hence change the behavior of '%pD' to print the full path of that file. > > > > Precision is never going to be used with %p (or any of its kernel > > extensions) if -Wformat is turned on. > > > Link: https://lore.kernel.org/lkml/CAHk-=wimsMqGdzik187YWLb- > ru+iktb4MYbMQG1rnZ81dXYFVg@xxxxxxxxxxxxxx/ [1] > > > > > > Shouldn't be blank lines in the tag block. I have an impression that I have > commented on this already... Okay > > ... > > > -last components. %pD does the same thing for struct file. > > +last components. %pD prints full file path together with mount-related > > I guess you may also convert double space to a single one. > Okay -- Cheers, Justin (Jia He)
