Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Fangrui Song <maskray@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr
From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Date: Mon, 21 Jun 2021 21:09:22 +0200
Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Bill Wendling <wcw@xxxxxxxxxx>, Sami Tolvanen <samitolvanen@xxxxxxxxxx>, Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>, Masahiro Yamada <masahiroy@xxxxxxxxxx>, Nathan Chancellor <nathan@xxxxxxxxxx>, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, clang-built-linux <clang-built-linux@xxxxxxxxxxxxxxxx>, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Martin Liska <mliska@xxxxxxx>, Marco Elver <elver@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Linux Doc Mailing List <linux-doc@xxxxxxxxxxxxxxx>, Linux Kbuild mailing list <linux-kbuild@xxxxxxxxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>, Johannes Berg <johannes.berg@xxxxxxxxx>, linux-toolchains@xxxxxxxxxxxxxxx
In-reply-to: <20210621182418.57qbumtovysrlkwy@google.com>
References: <20210618233023.1360185-1-ndesaulniers@google.com> <20210618233023.1360185-2-ndesaulniers@google.com> <CANiq72kjyiAQn2+ijZKFo7SY3z+dCV6fGXYP1O_Mq7Ui3EqSzQ@mail.gmail.com> <CANiq72nbbqeD2dv3z0y3rN-_kdnh=9-pD7oSyWUfaG8oJ2y_8A@mail.gmail.com> <CAKwvOd=B6LV9rZmtPacfz_F10jj1wrovoGu8yvdOqKZ69-T6mQ@mail.gmail.com> <20210621182418.57qbumtovysrlkwy@google.com>

On Mon, Jun 21, 2021 at 8:24 PM Fangrui Song <maskray@xxxxxxxxxx> wrote:
>
> Also a reminder that __GCC4_has_attribute___no_profile in v1 misses two
> underscores. v2 no_profile_instrument_function may need to fix this.

Good catch! Yes, it is missing the last two.

Cheers,
Miguel

References:
- [PATCH 0/2] no_profile fn attr and Kconfig for GCOV+PGO
  - From: Nick Desaulniers
- [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr
  - From: Nick Desaulniers
- Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr
  - From: Miguel Ojeda
- Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr
  - From: Miguel Ojeda
- Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr
  - From: Nick Desaulniers
- Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr
  - From: Fangrui Song

Prev by Date: Re: [PATCH 2/2] Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO
Next by Date: Re: [PATCH 2/2] Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO
Previous by thread: Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr
Next by thread: [PATCH 2/2] Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]