On 6/18/21 6:56 PM, Steven Rostedt wrote:
>> + return simple_read_from_buffer(ubuf, cnt, ppos, buf, len);
> Egad, this entire patch is filled with whitespace issues!
>
> Please check your other patches too.
<talking to myself>
daniel daniel daniel.... after all these years...
</talking to myself>
Sorry... it was only in this patch.
>> +}
>> +
>
>> +
>> +#define ULL_STR_SIZE 22 /* 20 digits max */
> Nit. I'd make this 24, just to be integer aligned. I mean, it's used as:
>
>
> trace_min_max_read(struct file *filp, char __user *ubuf, size_t cnt,
> loff_t *ppos)
> {
> struct trace_min_max_param *param = filp->private_data;
> char buf[ULL_STR_SIZE];
> u64 val;
> int len;
>
> Probably should reverse the above as well, that way if you do have
> ULL_STR_SIZE as 24, then the int len, will fit right in before the u64
> val. Although, I think compilers are free to optimize that too :-/
I will do that!
-- Daniel
> -- Steve
>
