Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, "Alex Williamson" <alex.williamson@xxxxxxxxxx>
Subject: Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()
From: Kirti Wankhede <kwankhede@xxxxxxxxxx>
Date: Thu, 17 Jun 2021 01:50:49 +0530
Cc: David Airlie <airlied@xxxxxxxx>, Tony Krowiak <akrowiak@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Jason Herne <jjherne@xxxxxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, <kvm@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
In-reply-to: <20210615133519.754763-9-hch@lst.de>
References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-9-hch@lst.de>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

-static int mtty_reset(struct mdev_device *mdev)
+static int mtty_reset(struct mdev_state *mdev_stte)


Nit pick:
s/mdev_stte/mdev_state

+static const struct vfio_device_ops mtty_dev_ops = {
+	.name = "vfio-mdev",


I think name should be different that 'vfio-mdev', probably
'vfio-mdev-mtty' or 'vfio-mtty'

Rest looks fine to me.

Reviewed-by: Kirti Wankhede <kwankhede@xxxxxxxxxx>

References:
- Allow mdev drivers to directly create the vfio_device (v3)
  - From: Christoph Hellwig
- [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind
Next by Date: Re: [PATCH v2 04/29] docs: admin-guide: hw-vuln: avoid using ReST :doc:`foo` markup
Previous by thread: Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()
Next by thread: [PATCH 09/10] vfio/mdpy: Convert to use vfio_register_group_dev()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]