On 06/13/21 at 05:44pm, Jonathan Corbet wrote: > Jonathan Corbet <corbet@xxxxxxx> writes: > > > Baoquan He <bhe@xxxxxxxxxx> writes: > > > >> Some parts of the guide are aged, hence need be updated. > >> > >> 1) The backup area of the 1st 640K on X86_64 has been removed > >> by below commits, update the description accordingly. > >> > >> commit 7c321eb2b843 ("x86/kdump: Remove the backup region handling") > >> commit 6f599d84231f ("x86/kdump: Always reserve the low 1M when the crashkernel option is specified") > >> > >> 2) Sort out the descripiton of "crashkernel syntax" part. > >> > >> 3) And some other minor cleanups. > >> > >> Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > > > > Applied, thanks. > > Actually, this patch added a docs build warning: > > /stuff/k/git/kernel/Documentation/admin-guide/kdump/kdump.rst:286: WARNING: Literal block ends without a blank line; unexpected unindent. > > I've gone ahead and inserted the blank line to fix this. In the future, > please build-test your changes to make sure that you are not adding new > warnings. Thanks, jon. I didn't know doc change can cause build failure, so didn't build. Will remember this.