On 6/4/21 11:28 PM, Steven Rostedt wrote: >> +#ifdef CONFIG_X86_LOCAL_APIC > I wonder if we should move this into a separate file, making the > __trace_irq_entry() a more name space safe name and have it call that. > I have a bit of a distaste for arch specific code in a generic file. > I am placing the intel specific file in: arch/x86/kernel/trace_osnoise.c and the kernel/trace/trace_osnoise.h looks like this: #ifdef CONFIG_X86_LOCAL_APIC int osnoise_arch_register(void); int osnoise_arch_unregister(void); #else /* CONFIG_X86_LOCAL_APIC */ #define osnoise_arch_register() do {} while (0) #define osnoise_arch_unregister() do {} while (0) #endif /* CONFIG_X86_LOCAL_APIC */ This can be used by other archs as well... sound reasonable? -- Daniel >> +/** >> + * trace_intel_irq_entry - record intel specific IRQ entry >> + */ >> +void trace_intel_irq_entry(void *data, int vector) >> +{ >> + __trace_irq_entry(vector); >> +} >> +