On Thu, 03 Jun 2021 21:19:50 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote: > If tracing cleanups for trace_events.h are being done, perhaps > another bit of untidiness is the macro definition and uses of > __assign_str. This isn't a tracing cleanup, but adding new functionality. That said, > > $ git grep -w -1 __assign_str include/trace/trace_events.h > include/trace/trace_events.h- > include/trace/trace_events.h:#undef __assign_str > include/trace/trace_events.h:#define __assign_str(dst, src) \ > include/trace/trace_events.h- strcpy(__get_str(dst), (src) ? (const char *)(src) : "(null)"); > > Its definition has a semicolon as do most uses but a dozen handfuls of > other uses do not have a semicolon. It'd be more consistent to add a > semicolon to the uses without them and when done treewide, then remove > the semicolon from the macro declaration. I have no problem taking a clean up patch that adds semicolons to all use cases of "__assign_str()" and ever remove the one from where it is defined. As long as it doesn't break any builds, I'm fine with that. -- Steve
