Re: [PATCH v26 23/30] x86/cet/shstk: Handle thread shadow stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Yu, Yu-cheng" <yu-cheng.yu@xxxxxxxxx>
Subject: Re: [PATCH v26 23/30] x86/cet/shstk: Handle thread shadow stack
From: Borislav Petkov <bp@xxxxxxxxx>
Date: Wed, 12 May 2021 17:56:49 +0200
Cc: x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Balbir Singh <bsingharora@xxxxxxxxx>, Cyrill Gorcunov <gorcunov@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Eugene Syromiatnikov <esyr@xxxxxxxxxx>, Florian Weimer <fweimer@xxxxxxxxxx>, "H.J. Lu" <hjl.tools@xxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Nadav Amit <nadav.amit@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>, Vedvyas Shanbhogue <vedvyas.shanbhogue@xxxxxxxxx>, Dave Martin <Dave.Martin@xxxxxxx>, Weijiang Yang <weijiang.yang@xxxxxxxxx>, Pengfei Xu <pengfei.xu@xxxxxxxxx>, Haitao Huang <haitao.huang@xxxxxxxxx>
In-reply-to: <a645aefc-632f-b1eb-4f4e-1c5b0f9e75d5@intel.com>
References: <20210427204315.24153-1-yu-cheng.yu@intel.com> <20210427204315.24153-24-yu-cheng.yu@intel.com> <YJlADyc/9pn8Sjkn@zn.tnic> <a645aefc-632f-b1eb-4f4e-1c5b0f9e75d5@intel.com>

On Tue, May 11, 2021 at 11:35:03AM -0700, Yu, Yu-cheng wrote:
> io_bitmap_share() does refcount_inc(&current->thread.io_bitmap->refcnt), and
> the function won't fail.  However, shadow stack allocation can fail.  So,
> maybe leave io_bitmap_share() at the end?

Yap, makes sense.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

References:
- [PATCH v26 00/30] Control-flow Enforcement: Shadow Stack
  - From: Yu-cheng Yu
- [PATCH v26 23/30] x86/cet/shstk: Handle thread shadow stack
  - From: Yu-cheng Yu
- Re: [PATCH v26 23/30] x86/cet/shstk: Handle thread shadow stack
  - From: Borislav Petkov
- Re: [PATCH v26 23/30] x86/cet/shstk: Handle thread shadow stack
  - From: Yu, Yu-cheng

Prev by Date: Re: [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols
Next by Date: Re: [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols
Previous by thread: Re: [PATCH v26 23/30] x86/cet/shstk: Handle thread shadow stack
Next by thread: [PATCH v26 25/30] x86/cet/shstk: Handle signals for shadow stack
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]