On Sat, May 08, 2021 at 03:17:44PM -0700, Linus Torvalds wrote: > On Sat, May 8, 2021 at 2:06 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > On Sat, May 08, 2021 at 01:39:45PM -0700, Linus Torvalds wrote: > > > > > +static inline int prepend_entries(struct prepend_buffer *b, const struct path *path, const struct path *root, struct mount *mnt) > > > > If anything, s/path/dentry/, since vfsmnt here will be equal to &mnt->mnt all along. > > Too subtle for me. > > And is it? Because mnt is from > > mnt = real_mount(path->mnt); > > earlier, while vfsmount is plain "path->mnt". static inline struct mount *real_mount(struct vfsmount *mnt) { return container_of(mnt, struct mount, mnt); }