Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Vladimir Oltean <olteanv@xxxxxxxxx>
Subject: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling
From: Richard Cochran <richardcochran@xxxxxxxxx>
Date: Sun, 18 Apr 2021 08:11:24 -0700
Cc: Yangbo Lu <yangbo.lu@xxxxxxx>, netdev@xxxxxxxxxxxxxxx, Vladimir Oltean <vladimir.oltean@xxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Vivien Didelot <vivien.didelot@xxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Claudiu Manoil <claudiu.manoil@xxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, UNGLinuxDriver@xxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20210418091842.slmcybvjfkvkatiq@skbuf>
References: <20210416123655.42783-1-yangbo.lu@nxp.com> <20210416123655.42783-2-yangbo.lu@nxp.com> <20210418091842.slmcybvjfkvkatiq@skbuf>
User-agent: Mutt/1.10.1 (2018-07-13)

On Sun, Apr 18, 2021 at 12:18:42PM +0300, Vladimir Oltean wrote:
> 
> How about not passing "clone" back to DSA as an argument by reference,
> but instead require the driver to populate DSA_SKB_CB(skb)->clone if it
> needs to do so?
> 
> Also, how about changing the return type to void? Returning true or
> false makes no difference.

+1

Thanks,
Richard

Follow-Ups:
- RE: [net-next 1/3] net: dsa: optimize tx timestamp request handling
  - From: Y.b. Lu

References:
- [net-next 0/3] Support ocelot PTP Sync one-step timestamping
  - From: Yangbo Lu
- [net-next 1/3] net: dsa: optimize tx timestamp request handling
  - From: Yangbo Lu
- Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling
  - From: Vladimir Oltean

Prev by Date: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling
Next by Date: Re: [PATCH 00/13] [RFC] Rust support
Previous by thread: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling
Next by thread: RE: [net-next 1/3] net: dsa: optimize tx timestamp request handling
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]