On Tue, 2021-04-13 at 20:44 -0700, Jakub Kicinski wrote: > ethtool_link_ksettings *); > + void (*get_fec_stats)(struct net_device *dev, > + struct ethtool_fec_stats > *fec_stats); why void ? some drivers need to access the FW and it could be an old FW/device where the fec stats are not supported. and sometimes e.g. in mlx5 case FW can fail for FW related businesses :)..