On 14/04/2021 19:21, Guenter Roeck wrote:
On Fri, Apr 09, 2021 at 10:13:30AM +0700, Quan Nguyen wrote:
Adds an MFD driver for SMpro found on the Mt.Jade hardware reference
platform with Ampere's Altra processor family.
Signed-off-by: Quan Nguyen <quan@xxxxxxxxxxxxxxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
---
drivers/mfd/Kconfig | 10 ++++++++++
drivers/mfd/simple-mfd-i2c.c | 6 ++++++
2 files changed, 16 insertions(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index d07e8cf93286..f7a6460f7aa0 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -77,6 +77,16 @@ config MFD_AS3711
help
Support for the AS3711 PMIC from AMS
+config MFD_SMPRO
+ tristate "Ampere Computing MFD SMpro core driver"
+ select MFD_SIMPLE_MFD_I2C
This is missing "depends on I2C".
Thanks Guenter to help pointing this out.
This fixes the issue reported by kernel test robot. Will include this in
next version.
+ help
+ Say yes here to enable SMpro driver support for Ampere's Altra
+ processor family.
+
+ Ampere's Altra SMpro exposes an I2C regmap interface that can
+ be accessed by child devices.
+
config MFD_AS3722
tristate "ams AS3722 Power Management IC"
select MFD_CORE
diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
index 87f684cff9a1..9a44655f5592 100644
--- a/drivers/mfd/simple-mfd-i2c.c
+++ b/drivers/mfd/simple-mfd-i2c.c
@@ -21,6 +21,11 @@ static const struct regmap_config simple_regmap_config = {
.val_bits = 8,
};
+static const struct regmap_config simple_word_regmap_config = {
+ .reg_bits = 8,
+ .val_bits = 16,
+};
+
static int simple_mfd_i2c_probe(struct i2c_client *i2c)
{
const struct regmap_config *config;
@@ -39,6 +44,7 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c)
static const struct of_device_id simple_mfd_i2c_of_match[] = {
{ .compatible = "kontron,sl28cpld" },
+ { .compatible = "ampere,smpro", .data = &simple_word_regmap_config },
{}
};
MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match);
