From: SeongJae Park <sjpark@xxxxxxxxx> On Sat, 10 Apr 2021 10:55:01 +0200 Greg KH <greg@xxxxxxxxx> wrote: > On Thu, Apr 08, 2021 at 01:48:48PM +0000, SeongJae Park wrote: > > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) > > +{ > > + const char * const file_names[] = {"attrs", "target_ids"}; > > + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops}; > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(file_names); i++) > > + debugfs_create_file(file_names[i], 0600, dir, ctx, fops[i]); > > + > > + return 0; > > +} > > Why do you have a function that can only return 0, actually return > something? It should be void, right? You're right, I will make it return void in the next spin. Thanks, SeongJae Park > > thanks, > > greg k-h >