On Fri, Mar 19, 2021 at 02:26:40PM -0700, Guenter Roeck wrote: > On Fri, Mar 19, 2021 at 01:55:44AM -0300, Jonas Malaco wrote: > > These are "all-in-one" CPU liquid coolers that can be monitored and > > controlled through a proprietary USB HID protocol. > > > > While the models have differently sized radiators and come with varying > > numbers of fans, they are all indistinguishable at the software level. > > > > The driver exposes fan/pump speeds and coolant temperature through the > > standard hwmon sysfs interface. > > > > Fan and pump control, while supported by the devices, are not currently > > exposed. The firmware accepts up to 61 trip points per channel > > (fan/pump), but the same set of trip temperatures has to be maintained > > for both; with pwmX_auto_point_Y_temp attributes, users would need to > > maintain this invariant themselves. > > > > Instead, fan and pump control, as well as LED control (which the device > > also supports for 9 addressable RGB LEDs on the CPU water block) are > > left for existing and already mature user-space tools, which can still > > be used alongside the driver, thanks to hidraw. A link to one, which I > > also maintain, is provided in the documentation. > > > > The implementation is based on USB traffic analysis. It has been > > runtime tested on x86_64, both as a built-in driver and as a module. > > > > Signed-off-by: Jonas Malaco <jonas@xxxxxxxxxxxx> > > Applied (after removing the now unnecessary spinlock.h include). Thanks for catching/fixing that. Jonas > > Thanks, > Guenter
