Re: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Laight <David.Laight@xxxxxxxxxx>
Subject: Re: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Mon, 15 Mar 2021 18:36:54 +0200
Cc: Bartosz Golaszewski <brgl@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Kent Gibson <warthog618@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "linux-gpio@xxxxxxxxxxxxxxx" <linux-gpio@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
In-reply-to: <6bc83972093a4be4ad163069a437ec25@AcuMS.aculab.com>
References: <20210315091400.13772-1-brgl@bgdev.pl> <20210315091400.13772-3-brgl@bgdev.pl> <6bc83972093a4be4ad163069a437ec25@AcuMS.aculab.com>

On Mon, Mar 15, 2021 at 5:33 PM David Laight <David.Laight@xxxxxxxxxx> wrote:
> From: Bartosz Golaszewski
> > Sent: 15 March 2021 09:14
> >
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > For better readability and maintenance: use the (1UL << bit) for flag
> > definitions.
>
> If the values ever get printed in hex the hex definitions are
> actually more useful.

Huh?!


-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH v5 00/11] gpio: implement the configfs testing module
  - From: Bartosz Golaszewski
- [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags
  - From: Bartosz Golaszewski
- RE: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags
  - From: David Laight

Prev by Date: Re: [PATCH] docs: kbuild: Fix a typo in the file Kconfig.recursion-issue-02
Next by Date: [PATCH v1 1/1] gpio: mockup: Adjust documentation to the code
Previous by thread: RE: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags
Next by thread: [PATCH v5 09/11] selftests: gpio: provide a helper for reading chip info
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]