On Thu, Mar 4, 2021 at 1:59 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, Mar 04, 2021 at 11:24:45AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > > > The 'extern' keyword doesn't have any benefits in header files. Remove it. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > A few nitpicks below. > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > --- Hi Andy, regarding this patch and other places where you raise issues with line breaking: I believe this is purely a question of taste. There are no guidelines on line breaking in the docs. I will leave it as it is here because it's not better or worse than your version, just different. Same for exceeding 80 characters - I personally believe it's justified when the line looks better but whenever it can be cleanly broken, it's better to stay within the limit. Best Regards, Bartosz
