On Sat, Mar 06, 2021 at 05:33:01PM -0800, Wren Turkal wrote: > Before, the bus type related APIs that were defined in the > include/linux/device/bus.h were not referenced anywhere in the docs, so > I linked it to the bus types api documentation. I think this is a good thing to do. > +++ b/Documentation/driver-api/driver-model/bus.rst > @@ -144,3 +144,5 @@ sysfs directory using:: > > int bus_create_file(struct bus_type *, struct bus_attribute *); > void bus_remove_file(struct bus_type *, struct bus_attribute *); > + > +.. kernel-doc:: include/linux/device/bus.h Do you want to put a heading in front of it? I did this in xarray.rst: Functions and structures ======================== .. kernel-doc:: include/linux/xarray.h .. kernel-doc:: lib/xarray.c Also, I see that drivers/base/bus.c is included in driver-api/infrastructure.rst, and I feel that they should probably be included together?