Hi Jon, Greg, Rafael, The DEVICE_ATTR_* and ATTRIBUTE_GROUPS() helper macros have existed for more than a decade, but are still not mentioned in the driver-model device documentation. Hence this patch series adds them, including examples, to the documentation. Thanks for your comments! Geert Uytterhoeven (2): docs: driver-model: device: Add DEVICE_ATTR_{RO,RW} examples docs: driver-model: device: Add ATTRIBUTE_GROUPS() example .../driver-api/driver-model/device.rst | 23 ++++++++++++++----- 1 file changed, 17 insertions(+), 6 deletions(-) -- 2.25.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds