On Fri, Feb 26, 2021 at 07:29:39PM +0100, Maciej Kwapulinski wrote: > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes: > > > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > > <maciej.kwapulinski@xxxxxxxxxxxxxxx> wrote: > >> > .... > >> +#define GNA_DRV_VER "1.2.0" > > > > Nowadays the version is the Git SHA sum. > > > > right, "version" is present in about 7% of all modules And it should be removed from them. > do You mean version should be skipped over (automatically generated) > srcversion field? or maybe You suggest any (better) technique? Drop it entirely from the driver code, it means nothing when the driver is merged into the kernel tree. thanks, greg k-h
