Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver
From: "Catangiu, Adrian Costin" <acatan@xxxxxxxxxx>
Date: Tue, 9 Feb 2021 14:46:32 +0000
Accept-language: en-US
Cc: "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "Graf (AWS), Alexander" <graf@xxxxxxxxx>, "rdunlap@xxxxxxxxxxxxx" <rdunlap@xxxxxxxxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "ebiederm@xxxxxxxxxxxx" <ebiederm@xxxxxxxxxxxx>, "rppt@xxxxxxxxxx" <rppt@xxxxxxxxxx>, "0x7f454c46@xxxxxxxxx" <0x7f454c46@xxxxxxxxx>, "borntraeger@xxxxxxxxxx" <borntraeger@xxxxxxxxxx>, "Jason@xxxxxxxxx" <Jason@xxxxxxxxx>, "jannh@xxxxxxxxxx" <jannh@xxxxxxxxxx>, "w@xxxxxx" <w@xxxxxx>, "MacCarthaigh, Colm" <colmmacc@xxxxxxxxxx>, "luto@xxxxxxxxxx" <luto@xxxxxxxxxx>, "tytso@xxxxxxx" <tytso@xxxxxxx>, "ebiggers@xxxxxxxxxx" <ebiggers@xxxxxxxxxx>, "Woodhouse, David" <dwmw@xxxxxxxxxxxx>, "bonzini@xxxxxxx" <bonzini@xxxxxxx>, "Singh, Balbir" <sblbir@xxxxxxxxxx>, "Weiss, Radu" <raduweis@xxxxxxxxxx>, "corbet@xxxxxxx" <corbet@xxxxxxx>, "mst@xxxxxxxxxx" <mst@xxxxxxxxxx>, "mhocko@xxxxxxxxxx" <mhocko@xxxxxxxxxx>, "rafael@xxxxxxxxxx" <rafael@xxxxxxxxxx>, "pavel@xxxxxx" <pavel@xxxxxx>, "mpe@xxxxxxxxxxxxxx" <mpe@xxxxxxxxxxxxxx>, "areber@xxxxxxxxxx" <areber@xxxxxxxxxx>, "ovzxemul@xxxxxxxxx" <ovzxemul@xxxxxxxxx>, "avagin@xxxxxxxxx" <avagin@xxxxxxxxx>, "ptikhomirov@xxxxxxxxxxxxx" <ptikhomirov@xxxxxxxxxxxxx>, "gil@xxxxxxxx" <gil@xxxxxxxx>, "asmehra@xxxxxxxxxx" <asmehra@xxxxxxxxxx>, "dgunigun@xxxxxxxxxx" <dgunigun@xxxxxxxxxx>, "vijaysun@xxxxxxxxxx" <vijaysun@xxxxxxxxxx>, "oridgar@xxxxxxxxx" <oridgar@xxxxxxxxx>, "ghammer@xxxxxxxxxx" <ghammer@xxxxxxxxxx>
In-reply-to: <YBlAueoh12esXR2A@kroah.com>
References: <1612200294-17561-1-git-send-email-acatan@amazon.com> <1612200294-17561-2-git-send-email-acatan@amazon.com> <YBlAueoh12esXR2A@kroah.com>

On 02/02/2021, 14:09, "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

    On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote:
    > +static long sysgenid_ioctl(struct file *file,
    > +                                                unsigned int cmd, unsigned long arg)

    Very odd indentation style, checkpatch.pl didn't catch this?

Checkpatch.pl is happy with this, yes.
Will change it to a single tab nonetheless since it does look weird :)

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

References:
- [PATCH v5 0/2] System Generation ID driver and VMGENID backend
  - From: Adrian Catangiu
- [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver
  - From: Adrian Catangiu
- Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver
  - From: Greg KH

Prev by Date: Re: add a new dma_alloc_noncontiguous API v2
Next by Date: Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver
Previous by thread: Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver
Next by thread: Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]