On Tue, Feb 2, 2021 at 17:8:21, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Feb 02, 2021 at 04:58:50PM +0000, Gustavo Pimentel wrote: > > On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote: > > > > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman > > > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote: > > > > > > Just a kindly reminder. > > > > > > > > > > reminder of what? > > > > > > > > To review the patch set. I've done the requested modifications, but I > > > > didn't get any feedback if this patch series is fine or it needs > > > > something more to have an ACK. > > > > > > I do not knwo, I don't see anything my my review queue, sorry. > > > > I've resend the patch series. Let's see if appears now 😊 > > > > > > > > > If some feedback was provided, please accept my apologies. My email > > > > account was having some issues some time ago and I might not have > > > > received some emails. > > > > > > Check the archives please, that's what they are there for :) > > > > I have just checked, there isn't any feedback besides yours and Arnd > > Bergmann. > > Did you incorporate our review? Yes, I did. The driver initially was using the modules parameters, and based on your feedback I changed to sysfs using other drivers' implementation as a reference. I also the driver structure changed to use macros instead of bitfields. > > greg k-h
