Re: [PATCH 5/8] lib: bitmap: remove the 'extern' keyword from function declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 30, 2021 at 09:25:08PM +0100, Bartosz Golaszewski wrote:
> On Fri, Jan 29, 2021 at 4:59 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > On Fri, Jan 29, 2021 at 02:46:21PM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > >
> > > The 'extern' keyword doesn't have any benefits in header files. Remove it.
> >
> > > +int __bitmap_equal(const unsigned long *bitmap1,
> > > +                const unsigned long *bitmap2, unsigned int nbits);
> >
> > Why not
> >
> > int __bitmap_equal(const unsigned long *bitmap1, const unsigned long *bitmap2,
> >                    unsigned int nbits);
> >
> > and so on?
> >
> > It's even in 80 limit.
> >
> 
> I feel like this is purely a matter of taste. No rules define exactly
> how the lines should be broken. I prefer the longer part to be below,
> it just looks better to my eyes.

In above case it's even logically better to split as I proposed.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux