Hi Guenter, The 01/24/2021 00:14, Guenter Roeck wrote: > On Wed, Jan 13, 2021 at 07:08:48AM +0000, Troy Lee wrote: > > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and > > 16 FAN tacho channel. > > > > Changes since v1: > > - fixed review comments > > - fixed double-looped calculation of div_h and div_l > > - moving configuration to device tree > > - register hwmon driver with devm_hwmon_device_register_with_info() > > > > Signed-off-by: Troy Lee <troy_lee@xxxxxxxxxxxxxx> > > checkpatch says: > > total: 0 errors, 9 warnings, 26 checks, 779 lines checked > > This is a bit much. Please run checkpatch --strict and fix the issues > it reports. Please also fix the issues reported by 0-day as well as > the issues reported by the bindings robot, and resubmit. > > Thanks, > Guenter I'll fix the WARNINGs and CHECKs. Thanks, Troy Lee