Happy new year! On Wed, Dec 16, 2020 at 12:02:37PM -0800, Vipin Sharma wrote: > I like the idea of having a separate controller to keep the code simple and > easier for maintenance. Yeah, the more I think about it, keeping it separate seems like the right thing to do. What bothers me primarily is that the internal logic is identical between the RDMA controller and this one. If you wanna try factoring them out into library, great. If not, I don't think it should block merging this controller. We can get to refactoring later. Thanks. -- tejun