On Thu, Dec 10, 2020 at 9:29 AM Jonathan Corbet <corbet@xxxxxxx> wrote: > > On Tue, 8 Dec 2020 10:46:28 +0900 > JaeSang Yoo <js.yoo.5b@xxxxxxxxx> wrote: > > > On the update of Sphinx version to 2.4.4, the "six" library won't be > > installed automatically. (which is required by kfigure.py) > > > > Main reason of this issue were occurred by the requirements changed from > > the sphinx library. In Sphinx v1.7.9, six was listed on the > > install_requires, but it has been removed since 2.x > > > > The kfigure.py uses six library explicitly, adding six to > > requirements.txt seems reasonable > > > > Signed-off-by: JaeSang Yoo <jsyoo5b@xxxxxxxxx> > > --- > > Documentation/sphinx/requirements.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/sphinx/requirements.txt b/Documentation/sphinx/requirements.txt > > index 489f6626de67..5030d346d23b 100644 > > --- a/Documentation/sphinx/requirements.txt > > +++ b/Documentation/sphinx/requirements.txt > > @@ -1,3 +1,4 @@ > > docutils > > Sphinx==2.4.4 > > sphinx_rtd_theme > > +six > > Sigh...what we really need to do is to leave Python 2 behind. Until then, > though, we need to install "six". Patch applied, thanks. While I was surveying the Sphinx library, it requires Python version 3.5 as a minimum. You can figure it out in the setup.py of Sphinx library source: https://github.com/sphinx-doc/sphinx/blob/72ad5f2a/setup.py#L13-L15 I assume this would be a certain reason to leave Python 2 behind. The Sphinx check script recommends using virtualenv. How do you think about leaving Python 2 compatibility issue in this documentation script range? > jon
