> -----Original Message----- > From: Kishon Vijay Abraham I <kishon@xxxxxx> > Sent: Wednesday, November 11, 2020 8:36 AM > To: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Jonathan Corbet > <corbet@xxxxxxx>; Kishon Vijay Abraham I <kishon@xxxxxx>; Lorenzo > Pieralisi <lorenzo.pieralisi@xxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; > Jon Mason <jdmason@xxxxxxxx>; Jiang, Dave <dave.jiang@xxxxxxxxx>; > Allen Hubbe <allenbh@xxxxxxxxx>; Tom Joseph <tjoseph@xxxxxxxxxxx>; > Rob Herring <robh@xxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; linux- > pci@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-ntb@xxxxxxxxxxxxxxxx > Subject: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or > remote side of bridge > > Invoke ntb_link_enable() to enable the NTB/PCIe link on the local or remote > side of the bridge. > > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > --- > drivers/ntb/test/ntb_tool.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c index > b7bf3f863d79..8230ced503e3 100644 > --- a/drivers/ntb/test/ntb_tool.c > +++ b/drivers/ntb/test/ntb_tool.c > @@ -1638,6 +1638,7 @@ static int tool_probe(struct ntb_client *self, struct > ntb_dev *ntb) > > tool_setup_dbgfs(tc); > > + ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO); The tool expects the user to enable the link via debugfs according to documentation. Is this necessary? > return 0; > > err_clear_mws: > -- > 2.17.1
