Hi Andrew, On 11/30/20 9:20 PM, Andrew Lunn wrote: > On Mon, Nov 30, 2020 at 01:50:43PM +0530, Vignesh Raghavendra wrote: >> AM65 NUSS ethernet switch on K3 devices can be configured to work either >> in independent mac mode where each port acts as independent network >> interface (multi mac) or switch mode. >> >> Add devlink hooks to provide a way to switch b/w these modes. > > Hi Vignesh > > What is not clear is why you need this? Ports are independent anyway > until you add them to a bridge when using switchdev. > Default use case is to support multiple independent ports with no switching. Users can either use software bridge with multi-mac configuration or HW bridge for switch functionality. devlink hook enables users to select Hw supported switch functionality. We don't want to enable HW based switch support unless explicitly asked by user. This also matches previous generation of devices (DRA7xx and AM57xx) supported under drivers/net/ethernet/ti/cpsw_new.c In general, devlink will also be used to configure few more parameters (in addition to switch mode) such as host port in ALE_BYPASS mode (to allow all packets to be routed to host) etc. Regards Vignesh