On Fri 20-11-20 20:40:46, Muchun Song wrote: > On Fri, Nov 20, 2020 at 4:42 PM Michal Hocko <mhocko@xxxxxxxx> wrote: > > > > On Fri 20-11-20 14:43:04, Muchun Song wrote: > > [...] > > > > Thanks for improving the cover letter and providing some numbers. I have > > only glanced through the patchset because I didn't really have more time > > to dive depply into them. > > > > Overall it looks promissing. To summarize. I would prefer to not have > > the feature enablement controlled by compile time option and the kernel > > command line option should be opt-in. I also do not like that freeing > > the pool can trigger the oom killer or even shut the system down if no > > oom victim is eligible. > > Hi Michal, > > I have replied to you about those questions on the other mail thread. > > Thanks. > > > > > One thing that I didn't really get to think hard about is what is the > > effect of vmemmap manipulation wrt pfn walkers. pfn_to_page can be > > invalid when racing with the split. How do we enforce that this won't > > blow up? > > This feature depends on the CONFIG_SPARSEMEM_VMEMMAP, > in this case, the pfn_to_page can work. The return value of the > pfn_to_page is actually the address of it's struct page struct. > I can not figure out where the problem is. Can you describe the > problem in detail please? Thanks. struct page returned by pfn_to_page might get invalid right when it is returned because vmemmap could get freed up and the respective memory released to the page allocator and reused for something else. See? > > I have also asked in a previous version whether the vmemmap manipulation > > should be really unconditional. E.g. shortlived hugetlb pages allocated > > from the buddy allocator directly rather than for a pool. Maybe it > > should be restricted for the pool allocation as those are considered > > long term and therefore the overhead will be amortized and freeing path > > restrictions better understandable. > > Yeah, I agree with you. This can be an optimization. And we can > add it to the todo list and implement it in the future. Now the patch > series is already huge. Yes the patchset is large and the primary aim should be reducing functionality to make it smaller in the first incarnation. Especially when it is tricky to implement. Releasing vmemmap sparse hugepages is one of those things. Do you really need it for your usecase? -- Michal Hocko SUSE Labs
