On Thu, Nov 19, 2020 at 7:46 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Wed, 18 Nov 2020 17:26:53 -0800 Guenter Roeck wrote: > > On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote: > > > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > > > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > > > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.bupt@xxxxxxxxx wrote: > > > > > > From: Tao Ren <rentao.bupt@xxxxxxxxx> > > > > > > > > > > > > The patch series adds hardware monitoring driver for the Maxim MAX127 > > > > > > chip. > > > > > > > > > > Hi Tao > > > > > > > > > > Why are using sending a hwmon driver to the networking mailing list? > > > > > > > > > > Andrew > > > > > > > > Hi Andrew, > > > > > > > > I added netdev because the mailing list is included in "get_maintainer.pl > > > > Documentation/hwmon/index.rst" output. Is it the right command to find > > > > reviewers? Could you please suggest? Thank you. > > > > > > I have no idea why running get_maintainer.pl on > > > Documentation/hwmon/index.rst returns such a large list of mailing > > > lists and people. For some reason it includes everyone in the XDP > > > maintainer list. If anyone has an idea how that happens, please > > > let me know - we'll want to get this fixed to avoid the same problem > > > in the future. > > > > I found it. The XDP maintainer entry has: > > > > K: xdp > > > > This matches Documentation/hwmon/index.rst. > > > > $ grep xdp Documentation/hwmon/index.rst > > xdpe12284 > > > > It seems to me that a context match such as "xdp" in MAINTAINERS isn't > > really appropriate. "xdp" matches a total of 348 files in the kernel. > > The large majority of those is not XDP related. The maintainers > > of XDP (and all the listed mailing lists) should not be surprised > > to get a large number of odd review requests if they want to review > > every single patch on files which include the term "xdp". > > Agreed, we should fix this. For maintainers with high patch volume life > would be so much easier if people CCed the right folks to get reviews, > so we should try our best to fix get_maintainer. > > XDP folks, any opposition to changing the keyword / filename to: > > [^a-z0-9]xdp[^a-z0-9] Reducing regex makes sense. git grep -l -E "xdp"|wc -l 348 git grep -l -E "[^a-z0-9]xdp[^a-z0-9]"|wc -l 295 The false positive match was: +drivers/hwmon/pmbus/Kconfig +drivers/hwmon/pmbus/Makefile +drivers/hwmon/pmbus/xdpe12284.c +drivers/net/ethernet/natsemi/ns83820.c +drivers/net/ethernet/neterion/s2io.c +drivers/net/ethernet/neterion/s2io.h +drivers/net/ethernet/neterion/vxge/vxge-config.c +drivers/net/ethernet/neterion/vxge/vxge-config.h +drivers/net/ethernet/neterion/vxge/vxge-traffic.c +drivers/net/ethernet/sis/sis900.c +drivers/net/ethernet/sis/sis900.h +drivers/net/wireless/ath/ath5k/ath5k.h +drivers/net/wireless/ath/ath5k/base.c +drivers/net/wireless/ath/ath5k/debug.c +drivers/net/wireless/ath/ath5k/dma.c so it's pretty much hwmon and few drivers. I agree that sparing xdp from hwmon patches is a good thing :)
