> -----Original Message----- > From: Valentin Schneider [mailto:valentin.schneider@xxxxxxx] > Sent: Saturday, November 14, 2020 12:34 AM > To: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx> > Cc: corbet@xxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > Linuxarm <linuxarm@xxxxxxxxxx>; Ingo Molnar <mingo@xxxxxxxxxx>; Peter > Zijlstra <peterz@xxxxxxxxxxxxx>; Mel Gorman <mgorman@xxxxxxx>; Adrian > Freund <adrian@xxxxxxxxx> > Subject: Re: [PATCH v2 2/2] Documentation: scheduler: ask users to set > sched_debug cmdline > > > On 12/11/20 22:31, Barry Song wrote: > > From: Valentin Schneider <valentin.schneider@xxxxxxx> > > > > To print the schedule debug information, users need to set sched_debug > > cmdline or enable it by sysfs entry. > > > > Cc: Ingo Molnar <mingo@xxxxxxxxxx> > > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > > Cc: Mel Gorman <mgorman@xxxxxxx> > > Cc: Adrian Freund <adrian@xxxxxxxxx> > > Signed-off-by: Valentin Schneider <valentin.schneider@xxxxxxx> > > FYI, forging SoB, or any 'tag' other than Suggested-by / Reported-by is > frowned up. Now I do appreciate your effort to give me credit, but in this > case you should've used Suggested-by. As this part is actually your code, so I put an --author=" Valentin ..." in git commit so that git can show you are the author. Actually I was not sure if SoB was proper when I made it. My intention was only telling people the code was from you :-) > > Moreso, this really is a trivial change and doesn't deserve a separate > patch, so I would say just squash that into patch 1, and add > > Reviewed-by: Valentin Schneider <valentin.schneider@xxxxxxx> > > to it :) Cool, thanks. > > > Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> > > --- > > Documentation/scheduler/sched-domains.rst | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/scheduler/sched-domains.rst > b/Documentation/scheduler/sched-domains.rst > > index 55983b7e1098..8582fa5e9170 100644 > > --- a/Documentation/scheduler/sched-domains.rst > > +++ b/Documentation/scheduler/sched-domains.rst > > @@ -74,6 +74,8 @@ for a given topology level by creating a > sched_domain_topology_level array and > > calling set_sched_topology() with this array as the parameter. > > > > The sched-domains debugging infrastructure can be enabled by enabling > > -CONFIG_SCHED_DEBUG. This enables an error checking parse of the sched > domains > > -which should catch most possible errors (described above). It also prints out > > -the domain structure in a visual format. > > +CONFIG_SCHED_DEBUG and adding 'sched_debug' to your cmdline. If you > forgot to > > +tweak your cmdline, you can also flip the /sys/kernel/debug/sched_debug > > +knob. This enables an error checking parse of the sched domains which > should > > +catch most possible errors (described above). It also prints out the domain > > +structure in a visual format. Thanks Barry
