Re: [PATCH v1] scripts: kernel-doc: Restore anonymous enum parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 02, 2020 at 07:10:41PM +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 2 Nov 2020 19:48:46 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> escreveu:
> 
> > On Mon, Nov 02, 2020 at 06:27:43PM +0100, Mauro Carvalho Chehab wrote:
> > > Em Mon,  2 Nov 2020 19:06:37 +0200
> > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> escreveu:
> > >   
> > > > The commit d38c8cfb0571 ("scripts: kernel-doc: add support for typedef enum")
> > > > broke anonymous enum parsing. Restore it by relying on members rather than
> > > > its name.
> > > > 
> > > > Fixes: d38c8cfb0571 ("scripts: kernel-doc: add support for typedef enum")
> > > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > > Cc: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>  
> > > 
> > > Patch looks ok to me. Do you have an example about using it for
> > > anonymous enum?  
> > 
> > drivers/pinctrl/intel/pinctrl-intel.c
> > 
> 
> Thanks! 
> 
> Both include/linux/phy.h and drivers/pinctrl/intel/pinctrl-intel.c
> are parsing fine after your patch.
> 
> So,
> 
> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>

Thanks!

Jonathan, can we have this applied?

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux