Hi Matthew/Jon, Em Tue, 6 Oct 2020 13:53:34 +0200 Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> escreveu: > While not all EXPORT_SYMBOL*() symbols should be documented, > it seems useful to have a tool which would help to check what > symbols aren't documented. > > This is a first step on this direction. The tool has some > limitations. Yet, it could be useful for maintainers to check > about missing documents on their subsystems. > > Suggested-by: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> As suggested, I improved the script for it to provide some hints about what documentation is missing: $ ./scripts/check_docs_external_symbols drivers/media/v4l2-core/ warning: drivers/media/v4l2-core/videobuf-dma-contig.c: missing documentation for videobuf_queue_dma_contig_init videobuf_to_dma_contig videobuf_dma_contig_free warning: drivers/media/v4l2-core/v4l2-clk.c: missing documentation for v4l2_clk_get v4l2_clk_put v4l2_clk_enable v4l2_clk_disable v4l2_clk_get_rate v4l2_clk_set_rate v4l2_clk_register v4l2_clk_unregister __v4l2_clk_register_fixed v4l2_clk_unregister_fixed warning: include/media/v4l2-h264.h: file not included at Documentation/ warning: drivers/media/v4l2-core/v4l2-h264.c: file not included at Documentation/ warning: drivers/media/v4l2-core/videobuf-core.c: missing documentation for videobuf_alloc_vb videobuf_waiton videobuf_iolock videobuf_queue_to_vaddr videobuf_queue_core_init videobuf_queue_is_busy videobuf_queue_cancel videobuf_next_field videobuf_mmap_free __videobuf_mmap_setup videobuf_mmap_setup videobuf_reqbufs videobuf_querybuf videobuf_qbuf videobuf_dqbuf videobuf_streamon videobuf_streamoff videobuf_read_one videobuf_read_start videobuf_read_stop videobuf_stop videobuf_read_stream videobuf_poll_stream videobuf_mmap_mapper warning: drivers/media/v4l2-core/v4l2-mem2mem.c: file not included at Documentation/ warning: drivers/media/v4l2-core/v4l2-dev.c: missing documentation for video_device_alloc video_device_release video_device_release_empty video_devdata v4l2_prio_init v4l2_prio_change v4l2_prio_open v4l2_prio_close v4l2_prio_max v4l2_prio_check __video_register_device warning: drivers/media/v4l2-core/v4l2-dev.c: file not included at Documentation/ It also report things that shouldn't be documented, like those: $ ./scripts/check_docs_external_symbols drivers/media/pci/saa7134 warning: drivers/media/pci/saa7134/saa7134-video.c: missing documentation for saa7134_vb2_buffer_queue saa7134_enum_input saa7134_g_input saa7134_s_input saa7134_querycap saa7134_s_std saa7134_g_std saa7134_querystd saa7134_g_tuner saa7134_s_tuner saa7134_g_frequency saa7134_s_frequency warning: drivers/media/pci/saa7134/saa7134-core.c: missing documentation for saa7134_stop_streaming saa7134_ts_register saa7134_ts_unregister saa7134_set_gpio saa7134_dmasound_init saa7134_dmasound_exit saa7134_pgtable_free saa7134_pgtable_build saa7134_pgtable_alloc saa7134_set_dmabits warning: drivers/media/pci/saa7134/saa7134-ts.c: missing documentation for saa7134_ts_buffer_init saa7134_ts_buffer_prepare saa7134_ts_queue_setup saa7134_ts_start_streaming saa7134_ts_stop_streaming On this specific case, the saa7134 driver was split into multiple drivers, depending on the PCI sub-interfaces found on some complex media devices. IMO, it doesn't make any sense to document such symbols, as they aren't meant to be used outside saa7134 sub-drivers. - As noticed on its comments, this script is not perfect. It tries to avoid reporting false-positives by not processing files that it can't find all includes and by skipping non-functions. Yet, it can take a long time for it to parse the entire Kernel tree. So, at least on its current state, I don't think it would be a good idea to add it to the default build. Feel free to either take it as-is, to improve it, or to ignore ;-) Thanks, Mauro
