Re: [RFC PATCH 22/22] x86/fpu/xstate: Introduce boot-parameters for control some state component support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/1/20 1:39 PM, Chang S. Bae wrote:
> +		if ((custom & XFEATURE_MASK_XTILE) != XFEATURE_MASK_XTILE) {
> +			pr_warn("x86/fpu: Disable 0x%x components due to incorrect setup\n",
> +				XFEATURE_MASK_XTILE);
> +			custom &= ~(XFEATURE_MASK_XTILE);
> +		}

Saying "incorrect setup" is pretty much just wasting the bytes.  We
might as well just say "disabling due to random error", or "disabling
due to the easter bunny".  Each are equally actionable.  How about:

"error in xstate.disable parameter.  Additionally disabling '%s'".



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux