Em Thu, 10 Sep 2020 12:13:22 +0100 Matthew Wilcox <willy@xxxxxxxxxxxxx> escreveu: > On Thu, Sep 10, 2020 at 12:23:56PM +0200, Mauro Carvalho Chehab wrote: > > /** > > - * Allocate memory for splitting an entry of @order size into the order > > - * stored in the @xas. > > + * xas_split_alloc() - Allocate memory for splitting an entry of > > + * @order size into the order stored in the @xas. > > + * > > + * @xas: is the 'xarray operation state'. It may be either a pointer to > > + * an xa_state, or an xa_state stored on the stack. This is an unfortunate > > + * ambiguity. > > + * @entry: refers to something stored in a slot in the xarray > > + * @order: size of each entry > > + * @gfp: GFP allocation flags > > */ > > No. I'll do this properly. Thanks! Yeah, you should be able to document it better than me, as I'm not familiar with XArray subsystem ;-) > Sorry for forgetting to document the arguments. No problem. I know it was hard to identify such warnings in the past, as we used to have hundreds of warnings. Btw, while writing this series that finally gets rid of them, I even identified one such warning on media that slept though my review ;-) Thanks, Mauro
