On Fri, Jul 31, 2020 at 10:03:34AM +0530, Bharata B Rao wrote: > On Thu, Jul 30, 2020 at 04:21:01PM -0700, Ram Pai wrote: > > H_SVM_PAGE_IN hcall takes a flag parameter. This parameter specifies the > > way in which a page will be treated. H_PAGE_IN_NONSHARED indicates > > that the page will be shared with the Secure VM, and H_PAGE_IN_SHARED > > indicates that the page will not be shared but its contents will > > be copied. > > Looks like you got the definitions of shared and non-shared interchanged. Yes. Realized it after sending the patch. Will fix it. > > > > > However H_PAGE_IN_NONSHARED is not defined in the header file, though > > it is defined and documented in the API captured in > > Documentation/powerpc/ultravisor.rst > > > > Define H_PAGE_IN_NONSHARED in the header file. > > What is the use of defining this? Is this used directly in any place? > Or, are youp planning to introduce such a usage? I know the Hypervisor code currently has no use for that define. It assumes H_PAGE_IN_NONSHARED to be !H_PAGE_IN_SHARED. But H_PAGE_IN_NONSHARED is defined in the Ultravisor API, and hence has to be captured in the header, to stay consistent. RP
