Vladimir Oltean <olteanv@xxxxxxxxx> writes: > On Sat, Jul 18, 2020 at 12:13:42AM +0300, Sergey Organov wrote: >> Vladimir Oltean <olteanv@xxxxxxxxx> writes: >> >> > I've tried to collect and summarize the conclusions of these discussions: >> > https://patchwork.ozlabs.org/project/netdev/patch/20200711120842.2631-1-sorganov@xxxxxxxxx/ >> > https://patchwork.ozlabs.org/project/netdev/patch/20200710113611.3398-5-kurt@xxxxxxxxxxxxx/ >> > which were a bit surprising to me. Make sure they are present in the >> > documentation. >> >> As one of participants of these discussions, I'm afraid I incline to >> alternative approach to solving the issues current design has than the one >> you advocate in these patch series. >> >> I believe its upper-level that should enforce common policies like >> handling hw time stamping at outermost capable device, not random MAC >> driver out there. >> >> I'd argue that it's then upper-level that should check PHY features, and >> then do not bother MAC with ioctl() requests that MAC should not handle >> in given configuration. This way, the checks for phy_has_hwtstamp() >> won't be spread over multiple MAC drivers and will happily sit in the >> upper-level ioctl() handler. >> >> In other words, I mean that it's approach taken in ethtool that I tend >> to consider being the right one. >> >> Thanks, >> -- Sergey > > Concretely speaking, what are you going to do for > skb_defer_tx_timestamp() and skb_defer_rx_timestamp()? Not to mention > subtle bugs like SKBTX_IN_PROGRESS. I think that we have at least 2 problems here, and what I argue about above addresses one of them, while you try to get solution for another one. > If you don't address those, it's pointless to move the > phy_has_hwtstamp() check to net/core/dev_ioctl.c. No, even though solving one problem could be considered pointless without solving another, it doesn't mean that solving it is pointless. I do hope you will solve another one. I believe that logic in ethtool ioctl handling should be moved to clocks subsystem ioctl handling, and then ethtool should simply forward relevant calls to clocks subsystem. This will give us single implementation point that defines which ioctls go to which clocks, and single point where policy decisions are made, that, besides getting rid of current inconsistencies, will allow for easier changes of policies in the future. That also could be the point that caches time stamping configuration and gives it back to user space by ioctl request, freeing each driver from implementing it, along with copying request structures to/from user space that currently is done in every driver. I believe such changes are valuable despite particular way the SKBTX_IN_PROGRESS issue will be resolved. > The only way I see to fix the bug is to introduce a new netdev flag, > NETIF_F_PHY_HWTSTAMP or something like that. Then I'd grep for all > occurrences of phy_has_hwtstamp() in the kernel (which currently amount > to a whopping 2 users, 3 with your FEC "fix"), and declare this > netdevice flag in their list of features. Then, phy_has_hwtstamp() and > phy_has_tsinfo() and what not can be moved to generic places (or at > least, I think they can), and those places could proceed to advertise > and enable PHY timestamping only if the MAC declared itself ready. But, > it is a bit strange to introduce a netdev flag just to fix a bug, I > think. To me this sounds like a plan. In general (please don't take it as direct proposal to fix current issues), the most flexible solution would be to allow for user space to select which units will be time stamping (kernel clock being simply one of them), and to deliver all the time stamps to the user space. This will need clock IDs to be delivered along with time stamps (that is a nice thing to have by itself, as I already mentioned elsewhere in previous discussions.) For now it's just a raw idea, nevertheless to me it sounds like a suitable goal for future design. Thanks, -- Sergey
