On 7/16/20 12:49 PM, jim.cromie@xxxxxxxxx wrote:
>>> @@ -321,6 +321,8 @@ static int parse_linerange(struct ddebug_query *query, const char *first)
>>> } else {
>>> query->last_lineno = query->first_lineno;
>>> }
>>> + vpr_info("parsed line %d-%d\n", query->first_lineno,
>>> + query->last_lineno);
>>> return 0;
>>> }
>>
>> This bit seems like its unrelated to this patch and makes more sense in the
>> previous patch, or as separate patch...
>>
>> Thanks,
>>
>> -Jason
>>
>
> ok, I'll split it out, maybe merge with prior.
>
> Any other tweaks ?
> maybe move export last in series ?
sure.
> how do you feel about changing the pr_fmt
> to just mod-name "dynamic_debug" or "dyndbg"
>
So removing the function name? I'm fine either way.
Feel free to add Ack-by: Jason Baron <jbaron@xxxxxxxxxx> to the
series.
Thanks,
-Jason
