Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 15 Jul 2020 16:14:23 -0400
Cc: Simon Arlott <simon@xxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Bart Van Assche <bvanassche@xxxxxxx>, Damien Le Moal <Damien.LeMoal@xxxxxxx>, Pavel Machek <pavel@xxxxxx>, Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
In-reply-to: <20200715181145.GA17753@infradead.org> (Christoph Hellwig's message of "Wed, 15 Jul 2020 19:11:45 +0100")
Organization: Oracle
References: <f4a7b539-eeac-1a59-2350-3eefc8c17801@0882a8b5-c6c3-11e9-b005-00805fc181fe> <20200715181145.GA17753@infradead.org>

Christoph,

> Except for the fact that I think that usage of the BIT() macro is
> a horrible pattern, this looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me too.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot
  - From: Simon Arlott
- Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 2/4] KVM: x86: Introduce paravirt feature CR0/CR4 pinning
Next by Date: Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface
Previous by thread: Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot
Next by thread: [PATCH V4 0/3] cpufreq: Allow default governor on cmdline and fix locking issues
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]