On Tue, Jun 23, 2020 at 10:43 PM Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> wrote: > > Daniel Rosenberg <drosen@xxxxxxxxxx> writes: > > > - > > const struct dentry_operations ext4_dentry_ops = { > > - .d_hash = ext4_d_hash, > > - .d_compare = ext4_d_compare, > > + .d_hash = generic_ci_d_hash, > > + .d_compare = generic_ci_d_compare, > > }; > > #endif > > Can you make the structure generic since it is the same for f2fs and > ext4, which let you drop the code guards? Unless that becomes a problem for > d_revalidate with fscrypt, it is fine like this. > > -- > Gabriel Krisman Bertazi I unify them in a later patch, since I end up having to deal with fscrypt's d_revalidate. With that patch I'd end up undoing the export I'd add for this, so I'll skip that for the moment. -Daniel