> -----Original Message----- > From: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Sent: Wednesday, June 10, 2020 9:08 AM > > On Tue, Jun 09, 2020 at 06:22:40PM +0200, Piotr Stankiewicz wrote: > > There are several places in the kernel which check/ask for MSI or > > MSI-X interrupts. It would make sense to have a macro which defines > > all types of message signalled interrupts, to use in such situations. > > Add PCI_IRQ_MSI_TYPES, for this purpose. > > To state my objection voices in patch 3 here again: > > I think this is a very bad idea. Everyone knows what MSI and MSI-X mean and > that directly maps to specification. The new IMS interrupt scheme from the Intel > SIOV spec for example is a message signalled interrupt type as well and should > not be picked up automatically. > > If we want to change anything in this area we should probably remove > PCI_IRQ_ALL_TYPES instead.. Thanks, I've resent only the first patch as v4 of the chain, and dropped the rest.
