On Fri, May 15, 2020 at 2:44 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > To turn the KMSG_DUMP_* reasons into a more ordered list, collapse > the redundant KMSG_DUMP_(RESTART|HALT|POWEROFF) reasons into > KMSG_DUMP_SHUTDOWN. The current users already don't meaningfully > distinguish between them, so there's no need to, as discussed here: > https://lore.kernel.org/lkml/CA+CK2bAPv5u1ih5y9t5FUnTyximtFCtDYXJCpuyjOyHNOkRdqw@xxxxxxxxxxxxxx/ > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> Maybe it makes sense to mention in the commit log that for all three merged cases there is a pr_emerg() message logged right before the kmsg_dump(), thus the reason is distinguishable from the dmesg log itself. Reviewed-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
