Hi Jon, As asked, I changed the sphinx-pre-install script to print a different message for the PDF minimal recommended version. This change itself was easy, but, while testing the patch, I noticed some new weird behaviors when python venv is used. Basically, when using python venv, the venv environment will contain python itself. So, an attempt to create a new virtual environment to upgrade a version fails (at least here with Fedora 31). As I didn't notice this behavior before, maybe the problem was due to some Fedora upgrade. In any case, the approach I took should be generic enough to work past eventual distro packaging differences. - At the end, instead of a single patch, I ended needing to fix some other stuff, for this to work better. Oh well... The good news is that, at the cost of a slicely more complex logic, the script should now detect if a virtual environment works and to recommend activating a newer environment if it exists (instead of recommending to reinstall a venv using the name of an already-existing directory). Mauro Carvalho Chehab (5): scripts: sphinx-pre-install: only ask to activate valid venvs scripts: sphinx-pre-install: change the warning for version < 2.4.4 scripts: sphinx-pre-install: change recommendation text if venv exists scripts: sphinx-pre-install: fix a bug when using with venv scripts: sphinx-pre-install: change the output order scripts/sphinx-pre-install | 118 ++++++++++++++++++++++++++++--------- 1 file changed, 91 insertions(+), 27 deletions(-) -- 2.25.2
