On Wed, 15 Apr 2020 at 22:11, Jonathan Corbet <corbet@xxxxxxx> wrote: > > On Tue, 14 Apr 2020 15:37:43 +0100 > Peter Maydell <peter.maydell@xxxxxxxxxx> wrote: > > When kernel-doc generates a 'c:function' directive for a function > > one of whose arguments is a function pointer, it fails to print > > the close-paren after the argument list of the function pointer > > argument. For instance: > > > > long work_on_cpu(int cpu, long (*fn) (void *, void * arg) > Interesting. This appears to have affected well over 100 function > definitions in the docs, and nobody ever noticed. Good to know we're all > reading it closely :) Heh; I think my conclusion is "function signatures for APIs which don't provide and use a typedef for function-pointer-arguments are sufficiently hard to read that people don't notice simple errors in them", but then I prefer the with-typedef style to start with :-) thanks -- PMM
