Em Fri, 20 Mar 2020 16:28:23 +0100 Thomas Gleixner <tglx@xxxxxxxxxxxxx> escreveu: > Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> writes: > > The subject prefix for this is: 'futex:' Ok! > > > Adjust whitespaces and blank lines in order to get rid of this: > > > > ./kernel/futex.c:491: WARNING: Definition list ends without a blank line; unexpected unindent. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > > --- > > kernel/futex.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/futex.c b/kernel/futex.c > > index 67f004133061..dda6ddbc2e7d 100644 > > --- a/kernel/futex.c > > +++ b/kernel/futex.c > > @@ -486,7 +486,8 @@ static u64 get_inode_sequence_number(struct inode *inode) > > * The key words are stored in @key on success. > > * > > * For shared mappings (when @fshared), the key is: > > - * ( inode->i_sequence, page->index, offset_within_page ) > > + * ( inode->i_sequence, page->index, offset_within_page ) > > Sigh. Is there no better way to make this look sane both in the file and > in the docs? The enclosed patch would do the trick. I noticed another problem on it, however: "!@fshared" is not properly parsed by kernel-docs. It basically converts it to "!**fshared**", with is not what we want. IMHO, this specific case should be handled by kernel-doc script. I'll write a patch addressing this issue. Regards, Mauro --- [PATCH 04/17 v2] kernel: futex: get rid of a docs build warning Adjust whitespaces and blank lines in order to get rid of this: ./kernel/futex.c:491: WARNING: Definition list ends without a blank line; unexpected unindent. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> diff --git a/kernel/futex.c b/kernel/futex.c index 67f004133061..81ad379cbadf 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -486,10 +486,13 @@ static u64 get_inode_sequence_number(struct inode *inode) * The key words are stored in @key on success. * * For shared mappings (when @fshared), the key is: + * * ( inode->i_sequence, page->index, offset_within_page ) + * * [ also see get_inode_sequence_number() ] * * For private mappings (or when !@fshared), the key is: + * * ( current->mm, address, 0 ) * * This allows (cross process, where applicable) identification of the futex
