On 10/03/2020 22:26, Andrew Morton wrote: > On Tue, 10 Mar 2020 13:59:15 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > >>> +oops_all_cpu_backtrace: >>> +================ >>> + >>> +Determines if kernel should NMI all CPUs to dump their backtraces when >> >> I would much prefer that to be written without using NMI as a verb. > > "Non maskably interrupt" ;) > > I think it's OK. Concise and the meaning is clear. Hi Andrew, good idea heheh Thank you and all that reviewed the grammar/wording, certainly I can change that and resubmit. > > > Why do we need the kernel boot parameter? Isn't > /proc/sys/kernel/oops_all_cpu_backtrace sufficient? > I kept the kernel parameter as a consistency thing - every sysctl "*_all_cpubacktrace" has a respective kernel parameter, so I did the same (and if we get an oops booting a new kernel, this is maybe useful depending on the point we get the oops). But if it's a problem for you, I can remove the kernel parameter, your choice. Cheers, Guilherme
