Jonathan Corbet <corbet@xxxxxxx> wrote: > - We *really* don't want to be adding more files like this to the top > level; we have a directory hierarchy for a reason. This looks like it > belongs (mostly) in the core-api manual. Sure. Btw, the core-api/ is a bit of a miscellaneous bag - errseq, for example, should probably be in filesystems/. > - Can the user-space example be instead turned into a working program > under samples (or perhaps a test under tests/)? There is a working sample under samples/ also. See: https://lore.kernel.org/linux-fsdevel/158375623086.334846.16121725232323108842.stgit@xxxxxxxxxxxxxxxxxxxxxx/T/#t patches 7, 14 and 17. But no, this needs to be documented in the documentation also. Manual pages and testing (at least of key notifications) are available in a branch of the keyutils package. Actually, I need to amend my document to remove references to usb and block notifications. David