On Wed, Feb 26, 2020 at 12:31 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > Hi. > > > On Wed, Feb 26, 2020 at 6:02 AM Nick Desaulniers > <ndesaulniers@xxxxxxxxxx> wrote: > > > > Added to kbuild documentation. Provides more official info on building > > kernels with Clang and LLVM than our wiki. > > > > Suggested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > > Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > > Reviewed-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > --- > > Changes V1 -> V2: > > * s/On going/ongoing/ > > * add Randy's Suggested-by > > > I do not understand this tag update. > > As far as I saw the review process, > I do not think Randy deserves to have Suggested-by > because he just pointed out a typo (on going -> ongoing) : > https://patchwork.kernel.org/patch/11401189/#23179575 > > (or, was there off-line activity I had missed?) > Hi Masahiro, I got some credits from Nick for a review by seeing a typo - not on a review of the code - and H. Peter Anvin asked why. I am not sure what is here the correct credit to give. Depends a "Reviewed-by" and/or "Suggested-by" on a technical review? My POV: When people take time to look over patches they should get credits - sort of esteem. Regards, - Sedat - P.S.: Tipp: Use codespell to find typos :-). [1] https://git.kernel.org/linus/0e2e160033283e20f688d8bad5b89460cc5bfcc4 "x86/asm: Add _ASM_ARG* constants for argument registers to <asm/asm.h>"
