Hi Pavan,
On Wednesday 26 Feb 2020 at 15:21:34 (+0530), Pavan Kondeti wrote:
> On Mon, Feb 24, 2020 at 02:11:41PM +0000, Ionela Voinescu wrote:
>
> [...]
>
> > +static int __init init_amu_fie(void)
> > +{
> > + cpumask_var_t valid_cpus;
> > + bool have_policy = false;
> > + int cpu;
> > +
> > + if (!zalloc_cpumask_var(&valid_cpus, GFP_KERNEL) ||
> > + !zalloc_cpumask_var(&amu_fie_cpus, GFP_KERNEL))
> > + return -ENOMEM;
>
> The patch looks good to me. one minor comment here. In an unlikely
> scenario, valid_cpus which is a temporary mask can get allocated
> but amu_fie_cpus may not. In that case, we have to free valid_cpus
> here. I have seen some static code inspection tools catching these
> type of errors. If you happen to rebase this series, fix this.
>
Thank you for the review!
I am just about to push v5 and I'll add this fix as well.
Thank you,
Ionela.
> Thanks,
> Pavan
>
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
