Hi Russell, On Tue, 25 Feb 2020 at 11:39, Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote: > > Propagate the resolved link configuration down via DSA's > phylink_mac_link_up() operation to allow split PCS/MAC to work. > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > --- > drivers/net/dsa/b53/b53_common.c | 4 +++- > drivers/net/dsa/b53/b53_priv.h | 4 +++- > drivers/net/dsa/bcm_sf2.c | 4 +++- > drivers/net/dsa/lantiq_gswip.c | 4 +++- > drivers/net/dsa/mt7530.c | 4 +++- > drivers/net/dsa/mv88e6xxx/chip.c | 4 +++- > drivers/net/dsa/sja1105/sja1105_main.c | 4 +++- > include/net/dsa.h | 4 +++- > net/dsa/port.c | 3 ++- > 9 files changed, 26 insertions(+), 9 deletions(-) > It looks like you missed the felix_phylink_mac_link_up() conversion in this patch? (which also makes it fail to build, by the way, I'm supposed the Kbuild robot didn't already jump) Nonetheless, I've manually added the missing speed, duplex, tx_pause and rx_pause parameters, and it appears to work as before. Same for sja1105. Tested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx> Regards, -Vladimir
