On Wed, 19 Feb 2020 16:40:55 +0530 Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote: > Jakub mistakenly spotted one refcounting issue in one of my patchset: > https://lkml.org/lkml/2020/2/3/926 > > Then I tried to show him the kernel doc for kref and that's where I got this > example code slightly confusing. And while looking into the log, I noticed that > someone deleted the kref_put in error path mistakenly and that commit got > reverted after that. This issue was even discussed in stack overflow. > > http://stackoverflow.com/questions/20093127/why-kref-doc-of-linux-kernel-omits-kref-put-when-kthread-run-fail > > So I thought about making it more clear of why the kref_put is needed in error > path. OK, I've applied it, thanks. jon